Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce with equals issue #39

Open
naumansiddiqui4 opened this issue Dec 9, 2018 · 4 comments
Open

Nonce with equals issue #39

naumansiddiqui4 opened this issue Dec 9, 2018 · 4 comments

Comments

@naumansiddiqui4
Copy link

When I create nonce from server which contains a = in the nonce. It fails my test case parse_equal_sign_delimited_keys_values in a4 test suite.

I checked web-tester code in httptester.py and function parse_equal_sign_delimited_keys_values, code parses for key and values by splitting on =. This, I feel could be issue for my test case failing.

If my nonce does not have an equals sign, then my test case never fails.

@ibnesayeed
Copy link
Owner

Yes, that indeed is a bug. I will fix the WWW-Authenticate header parser.

@ibnesayeed
Copy link
Owner

By the way, do you have a specific situation where you want to have = sign in the values of attributes of WWW-Authenticate header?

@naumansiddiqui4
Copy link
Author

naumansiddiqui4 commented Dec 9, 2018 via email

@ibnesayeed
Copy link
Owner

ibnesayeed commented Dec 9, 2018

While I understand that quoted strings may contain = sign, the recommended way of generating nonce in this class is a Hex Digest which should not contain it. So, for the sake of simplicity, I would defer this fix for a later day, unless necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants