Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems when faux mousedown appears on node behind touchend node #19

Open
wkeese opened this issue Apr 15, 2014 · 2 comments
Open

problems when faux mousedown appears on node behind touchend node #19

wkeese opened this issue Apr 15, 2014 · 2 comments
Assignees

Comments

@wkeese
Copy link
Member

wkeese commented Apr 15, 2014

(I know we discussed this over email but I'm filing a ticket before I forget.)

See dojo/dojo@6117ba1, and https://bugs.dojotoolkit.org/ticket/15878#comment:24.

The problem happens for example when there is a <button> behind a Menu. The user clicks a menu item, which then closes the menu, and iOS sends a mousedown/mouseup/click event to the <button> rather than to the menu item.

It might also happen when tapping causes a scroll, for example opening an accordion container pane.

I don't have a test case offhand nor do I remember which platform this occurred, but I think it was iOS6. Perhaps @edurocher can help more, since it was his patch.

@edurocher
Copy link
Member

IIRC this occurred on dijit widgets on iPad, probably iOS6, and the test case was https://github.com/dojo/dijit/blob/master/tests/mobile.html I think, but I don't remember the precise scenario. The real problem IIRC was not the mousedown/up themselves, but the fact that with dojo/touch they arrived in a completely different order, e.g. click then mousedown/up, whereas the natural order is mousedown/up then click.

My patch just suppressed the native mousedown/up events fired after a synthetic click event, because it seemed unrealistic to modify the dijit code for this. A different solution would have been to also send synthetic mouseup/down events, so as to mimic the native order, but again that seemed complex and suppressing these events worked fine.

@wkeese
Copy link
Member Author

wkeese commented May 25, 2014

I made a simpler (i.e. pure HTML/CSS) test case in https://bugs.dojotoolkit.org/attachment/ticket/17816/popup-ios-bug.html.

@seb-pereira seb-pereira self-assigned this Jul 25, 2014
@seb-pereira seb-pereira added this to the 0.4.0 milestone Sep 3, 2014
@seb-pereira seb-pereira modified the milestones: 0.6.0, 0.4.0 Sep 18, 2014
@cjolif cjolif added the 3-high label Jan 27, 2015
@cjolif cjolif removed this from the 0.5.0 milestone Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants