-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
click events canceled on devices w/touch and mouse? #18
Comments
You are right, native click is absorbed and there is no synthetic click in that case. I also noticed that compatibility mouse events are generated when user tap on the screen, which leads to an extra set of pointer events (pointermove > pointerdown > pointerup) after the click event. |
Hmm, all these compatibility events really change the strategy. Does that mean that there's no reason to listen for touch events at all (on that platform)? |
Compat mouse events are generated only before a native click event, when user tap the screen. That's all. When you touch/scroll you only gets touch events. So we need to listen to both type of events. |
DPointer no more listen for touch event on Chrome Desktop (#31) until there is a clean way to differentiate compat mouse events from touch events (#32).
#31 should also fix that. |
You are right, even with #13 there is indeed a case that may impact click event on hitting SPACE/ENTER when Touch Events are supported by the bowser. Anyway, I am strongly considering to remove this click handler which is here only to fix a bug on Android 4.1.1. From our experience most 4.1.1 Android devices can be updated to (at least) 4.1.2 where this issue is no longer present. If we want to keep this fix it would involve to replace the touch events feature detection in |
Yes please remove any 4.1.1 specific fix if 4.1.2 is solving the issue. |
I might be wrong, but ISTM that mouse click events won't work on devices that support both touch and mouse (currently on Chrome on a laptop w/a touch screen). The reason is:
This problem was addressed in dojo/dojo@bcbba40 but AFAICT it's not addressed in dpointer.
On a similar note, it seems like your current code will hide click events from using SPACE or ENTER key while focused on a
<button>
.Again though, I might be misunderstanding.
The text was updated successfully, but these errors were encountered: