Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variational algorithms in brms backends #91

Open
martinmodrak opened this issue Feb 18, 2024 · 2 comments
Open

Support variational algorithms in brms backends #91

martinmodrak opened this issue Feb 18, 2024 · 2 comments

Comments

@martinmodrak
Copy link
Collaborator

Currently not supported, but should not be that hard to pipe through to the underlying Stan backend.

@lunafazio
Copy link
Contributor

I was looking into this some months ago and ended up uncovering an unfortunate interaction between cmdstanr VI output and the way that brms converts fits into rstan format regardless of backend: paul-buerkner/brms#1560

Since the error happens exclusively during summary printing of the $fit object, I don't think this should impact anything that SBC itself cares about, but just a heads up in case this comes up while developing the code.

@martinmodrak
Copy link
Collaborator Author

The current implementation of brms backends relies only on rename_pars - then it uses the inner fit$fit object to get draws. So as long as rename_pars works for the converted object, we are goood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants