Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when dragging off end of table #22

Open
GeorgeSealy opened this issue Apr 10, 2017 · 0 comments
Open

Crash when dragging off end of table #22

GeorgeSealy opened this issue Apr 10, 2017 · 0 comments

Comments

@GeorgeSealy
Copy link

To reproduce:

  • implement tableView: targetIndexPathForMoveFromRowAtIndexPath: toProposedIndexPath: in table view delegate
  • try to drag off the bottom of the table
  • crash

The crash is in HPReorderTableView.m, - (void)updateCurrentLocation:(UILongPressGestureRecognizer *)gesture. toIndexPath is nil which results in a crash. A possible fix is:

if ([self.delegate respondsToSelector:@selector(tableView:targetIndexPathForMoveFromRowAtIndexPath:toProposedIndexPath:)])
{
    if (toIndexPath == nil) {
        return;
    }
        
    toIndexPath = [self.delegate tableView:self targetIndexPathForMoveFromRowAtIndexPath:_reorderInitialIndexPath toProposedIndexPath:toIndexPath];
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant