Fix inheritance browser indentions by removing overridden MessageSet >> #initializeMessageList:
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>> #initializeMessageList: The old version of #initializeMessageList: stored in this override is no longer compatible with modern message set indentions as used by the inheritance browser. The sole purpose of this override was to preserve CSMethodReferences while string elements from the array are parsed. Since eem 12/16/2016 11:25 (Squeak 5.2), this invariant is already satisifed in the base system, thus the extension method is not needed any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of
#initializeMessageList: stored in this override is no longer compatible with modern message set indentions as used by the inheritance browser. The sole purpose of this override was to preserve CSMethodReferences while string elements from the array are parsed. Since eem 12/16/2016 11:25 (Squeak 5.2), this invariant is already satisfied in the base system, thus the extension method is not needed any longer.@codeZeilen This change is not compatible with Squeak 5.1 or lower. Do you think this is a concern? What extent of compatibility does this project guarantee?