Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link images with new git lfs? #111

Open
j4yk opened this issue Oct 26, 2015 · 5 comments
Open

Link images with new git lfs? #111

j4yk opened this issue Oct 26, 2015 · 5 comments

Comments

@j4yk
Copy link
Contributor

j4yk commented Oct 26, 2015

https://github.com/blog/2069-git-large-file-storage-v1-0

Would it be interesting to add sample images to the repo or externalize some test images with this new facility?

@krono
Copy link
Member

krono commented Oct 26, 2015

sounds good

@fniephaus
Copy link
Member

GitHub's Git LFS service is pretty limited:
https://help.github.com/articles/billing-plans-for-git-large-file-storage/#storage-limits

I'd suggest to use our artefacts repository instead.

@fniephaus
Copy link
Member

I've ran some experiments and using the bfg repo-cleaner, I was able to reduce the total size of the repository by 695M (from 831.8M to 136.8M). Here's the command I used:

bfg --delete-folders images <git repo>

It seems that random 4.5/4.6 images in ./images (which has been in .gitignore for some time now) are accountable for those 695M. Not sure if we want to rewrite the entire history because of that though.

@timfel
Copy link
Member

timfel commented May 12, 2016

@fniephaus that cleanup might be nice to have (as long as the current master's project can still rebase their branch onto the rewritten history). Since we now produce app bundles, i don't think the small images in the test folders are that bad, and I'm not planning on adding more images

@fniephaus
Copy link
Member

I don't think bfg breaks branches, so we should be fine. While we are at it, we could also put the test images somewhere where they can be downloaded as dependency, but let's talk about this tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants