Not working on 5.1

[143mailliw]

No description provided.

[fawind]

I will have a look at this in the next few days.

[fniephaus]

Have you tried this one yet?
https://github.com/HPI-SWA-Teaching/SWT16-Project-06

We haven't merged the code into this repository yet.

[fawind]

I could find the following issue using Squeak 5.1:

• The focus is not dropped when Algernon is closed and no item was searched. This results in a frozen world until Algernon is focused again. This also happens when activating Algernon using the settings menu.
• The default keyboard shortcut Cmd+<Space> does not work anymore. I could not find the root cause here. Changing it to something else worked fine.

I opened a PR on the other repo which should fix these bugs: hpi-swa-teaching/Algernon-Launcher#28

@ComputeLinux: Were these the problem you experienced?

If you want to use Algernon on 5.1 immediately, I recommend you using the above repo. There you can set a new keyboard shortcut in the settings menu. Additionally you need to add the line self dropFocus: hand. in Algernon>ALGCore>deactivate:. Otherwise you can wait until the changes are merged.

[marceltaeumel]

I recommend using event filters to trigger Algernon. ALGCore itself could act as a filter itself. For an example, see:

• PasteUpMorph >> #addKeyboardShortcuts
• PasteUpMorph >> #filterEvent:for:

Note that class objects can also be used as a filter. They only have to implement #filterEvent:for:.

If Algernon should act modally exclusive, work with the mouse focus. For an example, see:

• MenuMorph >> #activate:
• MenuMorph >> #mouseUp:

If is a good idea to keep track of the former mouse focus and keyboard focus holders and restore them once Algernon closes. With this, the world should never freeze. For your issue here, [CMD]+[.] should always revive event handling in the world.

For other issues with keyboard events, note that the recent macOS VMs have issues with correct key codes: OpenSmalltalk/opensmalltalk-vm#43

[fawind]

Makes sense. I will try to add this next week.