BC-8193 - Erweiterung und Registrierung BBB #5354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uidp
reviewed
Nov 26, 2024
| @@ -1,4 +1,5 @@ | |||
| export enum VideoConferenceScope { | |||
| BOARD = 'board', | |||
There was a problem hiding this comment.
AFAIK we wanted to attach a video conference to a board element. So shouldn't the scope then be the element and not the board?
uidp
reviewed
Nov 27, 2024
apps/server/src/modules/video-conference/service/video-conference.service.ts
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start implementing BBB on boards.
Links to Tickets or other pull requests
BC-8193
Changes
...
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.