onReceivedError is overloaded

[svantepolk]

Turbo has made a choice to funnel all errors into one callback and one datapoint, despite the datatype referring to 3 different things like it's a C union. It could be an HTTP status, a WebViewClient error code, or Turbo's JS error.

Splitting out the HTTP status codes isn't too difficult by looking at numbers over 299, but in the case of the latter, it actually collides with an existing WebViewClient error code. This makes it difficult to figure out whether the 'turbo didn't load' error actually occurred, or if some other "Generic error" occurred.

turbo-android/turbo/src/main/kotlin/dev/hotwire/turbo/session/TurboSession.kt

Line 458 in 8e753ef

callback { it.onReceivedError(-1) }

https://developer.android.com/reference/android/webkit/WebViewClient#ERROR_UNKNOWN

[jayohms]

There's now a comprehensive solution in #317 with custom error types.