Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Handles after creating and closing a service #27

Open
Supereg opened this issue Nov 14, 2022 · 1 comment
Open

Open Handles after creating and closing a service #27

Supereg opened this issue Nov 14, 2022 · 1 comment
Labels
bug Something isn't working long running Issues which should be excluded from the stale bot

Comments

@Supereg
Copy link
Member

Supereg commented Nov 14, 2022

Analysis

When creating a new responder and a new ciao service, not evening advertising it, and thereafter destroying the ciao service again there are still open handles in the system.

// TODO fix: CiaoAdvertiser constructor creates open handles!
// const advertiser = new CiaoAdvertiser(accessoryInfoUnpaired);

advertiser.destroy();

Expected Behavior

There shouldn't be any open handles (e.g. sockets, timeouts, etc). This e.g. stops the process from exiting, specifically noticeable in testing environments.

Steps To Reproduce

In the environment of HAP-NodeJS do the following code steps to reproduce:

const advertiser = new CiaoAdvertiser(accessoryInfoUnpaired);

// ....

advertiser.destroy();

Logs

-

Configuration

-

Environment

  • OS: macOS 13.0.1
  • Software: HAP-NodeJS 0.11.0
  • Node: 19.0.1
  • npm: 8.19.2

Process Supervisor

not applicable

Additional Context

No response

@Supereg Supereg added the bug Something isn't working label Nov 14, 2022
@Supereg Supereg changed the title Open Handles After creating and closing a service Open Handles after creating and closing a service Nov 14, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 15, 2022
@Supereg Supereg added long running Issues which should be excluded from the stale bot and removed stale labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working long running Issues which should be excluded from the stale bot
Projects
None yet
Development

No branches or pull requests

1 participant