Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] enhancement - Add "wieder" (again) to list of skip words #2442

Open
Lesekater opened this issue Nov 1, 2024 · 4 comments
Open

[de] enhancement - Add "wieder" (again) to list of skip words #2442

Lesekater opened this issue Nov 1, 2024 · 4 comments
Labels

Comments

@Lesekater
Copy link

Lesekater commented Nov 1, 2024

I used the word "wieder" at the end of an sentence without thinking about it and realized that this makes commands invalid. Can you think of any problems with adding "wieder" as an optional filler word for some commands?

Screenshot_20241101-182732
Screenshot_20241101-182844

@Lesekater Lesekater changed the title [de] enhancement - Support für "Wieder" als füllwort [de] enhancement - Support for "Wieder" as filler Nov 1, 2024
@andreasbrett
Copy link
Contributor

@mib1185 what do you think? Might be better to not make it a global ignored word but only have this right before actions like "an", "aus" etc

@mib1185
Copy link
Contributor

mib1185 commented Nov 14, 2024

I think this should be considered in a bigger round (a discussion) since this also comes up in other languages.

@mib1185 mib1185 changed the title [de] enhancement - Support for "Wieder" as filler [de] enhancement - Add "wieder" (again) to list of skip words Nov 14, 2024
@mib1185
Copy link
Contributor

mib1185 commented Nov 14, 2024

i've placed this question on the language-leader discord channel - will keep you posted

@duhow duhow added the lang: de label Nov 18, 2024
@mib1185
Copy link
Contributor

mib1185 commented Nov 22, 2024

Sorry for late reply. We've discussed this and came to the conclusion to not add wieder to the skip list, since it would indicates some context awareness of the intents based conversation agent, which is just not given (in opposite to ai based agents like ollama or openai)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants