-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate panel.widgets.DataFrame proposal #7473
Comments
I think this is a good idea; I wonder if there's a way to include a lightweight version of tabulator, ref #5131 Also, I think the title might be misleading unless I understand incorrectly; it should be |
I may be missing something, but will Couldn't the goatcounter numbers also mean that |
@hoxbro Deprecation to me is to entirely remove a feature so there will no longer have DataFrame widget in Panel. I don't think it makes sense to make change to pn.widgets.DataFrame to use the Tabulator widget, there'll be 2 widgets with different names that do exactly the same thing. |
No,
I don't buy this, I think it's 99% down to popularity not complexity. Overall I'm fine with sunsetting |
The real benefit of dropping DataFrame would be to stop loading the bokeh-tables.js bundle, which adds 300 KB to all our apps. That would require some re-architecting though because Tabulator reuses some of the formatters defined in that bundle. |
I also think it is mostly do to popularity. Though, I do think the many features of the Tabulator makes it more likely candidate to look up and revisit the site. I know from my self that I use that page the most.
Earlier the title was Tabulator and not DataFrame, which was what Andrew refenced to. |
Definitely true! The SlickGrid based
Ah, thanks, just wanted to be clear that we're talking about the widget not the pane, as was referenced by @ahuang11's comment. |
Oh wow, I totally forgot there was pn.widgets.DataFrame. Totally in favor of deprecating it completely. |
@thuydotm does I like that we look at some stats! :) Two other places interesting to look into would be Github and HoloViz Discourse.
Does that include objects that are not called or cannot be called
I'm not entirely sure about my little plan above but I am 100% sure renaming things is a pain so we have to think through all that carefully, specially if as Philipp hinted there's a later phase where we migrate users towards a more generic name (we try indeed to avoid naming things after their implementation). The current scheme is |
https://panel.holoviz.org/reference/widgets/DataFrame.html
Feature Overview
The DataFrame widget allows displaying and editing a pandas DataFrame.
Deprecation Proposal
I propose deprecating this feature in Panel. DataFrame docs also stated that the widget will be replaced with the Tabulator widget. So this may be a good time to actually do it.
Impact Assessment
pn.widgets.DataFrame
on Github, there're 164 code results: https://github.com/search?q=pn.widgets.DataFrame&type=codeThis means people still look for and use DataFrame but they are getting more used to Tabulator. DataFrame is a very common name/term though.
Effort Involved
Tabulator is to replace DataFrame so it supports all features that DataFrame supports, and also new features have been written to Tabulator. We even specified in the docs this deprecation so I'd say this is ready to go.
The primary remaining tasks include:
The text was updated successfully, but these errors were encountered: