Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Improve library #41

Open
4 of 6 tasks
jubianchi opened this issue Mar 9, 2016 · 6 comments
Open
4 of 6 tasks

Improve library #41

jubianchi opened this issue Mar 9, 2016 · 6 comments

Comments

@jubianchi
Copy link
Member

jubianchi commented Mar 9, 2016

I recently opened 3 linked PRs and they all need to be discussed correctly to be integrated altogether.

Let's sum-up:

The #38 and #40 are ready, event though the #38 is kind of blocked by #39. What I think we should do:


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Hywan
Copy link
Member

Hywan commented Mar 9, 2016

Why should we disallow constant to start by a digit? I don't see why is it an issue here.

@jubianchi
Copy link
Member Author

@Hywan because if we don't, we can't support generic notations for hex/bin/oct...

Or we could be we'll have to enforce conventions like "A variables name can start with a digit but can't start with 0x or 0b". The same applies to constants: they can start with digits but not 0X which will be recognized as a hex notation.

@Hywan
Copy link
Member

Hywan commented Mar 9, 2016

Good. So 👍 for closing #39, 👍 to restore previous constant names, and 👍 for #40 (but its testing suite must be updated and robust).

@jubianchi
Copy link
Member Author

@Hywan will do ;) Thanks!

@Hywan
Copy link
Member

Hywan commented Apr 8, 2016

Some news?

@Hywan
Copy link
Member

Hywan commented Aug 12, 2016

ping?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants