google authentication #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google.auth.mp4Output |
Abhishek01039
suggested changes
Mar 5, 2022
| import '../domain/authentication_firebase_provider.dart'; | ||
| import '../domain/google_sign_in_provider.dart'; | ||
|
|
||
| class AuthenticationRepository { |
There was a problem hiding this comment.
Can you please create abstract repository?
Please take a reference from home feature.
|
|
||
| class AuthenticationFailiure extends AuthenticationState { | ||
| final String message; | ||
| AuthenticationFailiure({ |
There was a problem hiding this comment.
Can you please move this constructor first?
https://dart-lang.github.io/linter/lints/sort_constructors_first.html
| this.name, | ||
| }); | ||
|
|
||
| AuthenticationDetail copyWith({ |
| @@ -34,7 +34,7 @@ dependencies: | |||
| after_layout: ^1.1.0 | |||
| http: ^0.13.3 | |||
| get_it: ^7.2.0 | |||
|
|
|||
| google_sign_in: | |||
There was a problem hiding this comment.
Please add the version number here.
| yield AuthenticationLoading(); | ||
| await _authenticationRepository.unAuthenticate(); | ||
| } catch (error) { | ||
| print('Error occured while logging out. : ${error.toString()}'); |
There was a problem hiding this comment.
Can you please remove print statements and use logger?
| @@ -36,10 +36,11 @@ android { | |||
| defaultConfig { | |||
| // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). | |||
| applicationId "dev.hireflutter.starterKit" | |||
| minSdkVersion 16 | |||
| minSdkVersion 19 | |||
There was a problem hiding this comment.
Is it necessary to increase the version of minSdkVersion?
japatel225
suggested changes
Apr 13, 2022
| @@ -156,116 +159,181 @@ class _LoginScreenState extends State<LoginScreen> { | |||
| } | |||
|
|
|||
| return Scaffold( | |||
| body: Padding( | |||
There was a problem hiding this comment.
Since the build method is getting too long, I think we should break it down into smaller parts (widgets or methods as suitable depending on the case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.