Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/basic-test-env-setup #484

Merged
merged 22 commits into from
Apr 4, 2024
Merged

test/basic-test-env-setup #484

merged 22 commits into from
Apr 4, 2024

Conversation

jszuminski
Copy link
Contributor

  1. Add unit tests
  2. Add visual regression tests
  3. Add proper GitHub actions to run those tests on GH

@jszuminski jszuminski self-assigned this Feb 13, 2024
jszuminski and others added 14 commits March 19, 2024 12:28
@jszuminski
Merge branch 'master' into test/basic-test-env-setup
cdf4044
@jszuminski
Tests: added a GH unit test workflow.
e16173c
@jszuminski
Tests: fixed ESlint error, added eslint-check GH workflow.
2f9b374
@jszuminski
Tests: added babel packages necessary for import/export in Mocha tests.
2fa0586
@jszuminski
Tests: added mocha config.
b3a0187
@jszuminski
Tests: switched to npm i instead of npm ci for unit tests.
e553c37
@jszuminski
Tests: got rid of the chai library, testing GH actions with assert.
32c0e9c
@jszuminski
Tests: imported back expect, testing GH action.
8115e8d
@jszuminski
Tests: added esm for unit tests.
fa5b339
@jszuminski
Tests: switched from Mocha to Jest for easier integrations and automa…
8912ad8 
…tions.
@jszuminski
Tests: added unit tests for cache.js.
5c01a2f
@jszuminski
Tests: added unit tests for the utility methods.
042a24e
@jszuminski
Bumped up required Node to 18.x.x because of updated Puppeteer versio…
90a55e1 
…n requirements.
@jszuminski
Merge branch 'master' into test/basic-test-env-setup
bdcbfe9
@jszuminski jszuminski marked this pull request as ready for review March 25, 2024 11:36
@PaulDalek PaulDalek requested a review from cvasseng April 3, 2024 15:28
PaulDalek
PaulDalek approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@PaulDalek PaulDalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@PaulDalek PaulDalek merged commit c8451d8 into master Apr 4, 2024
2 checks passed
@PaulDalek PaulDalek deleted the test/basic-test-env-setup branch April 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDalek PaulDalek PaulDalek approved these changes

@cvasseng cvasseng Awaiting requested review from cvasseng

Assignees

@jszuminski jszuminski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jszuminski @PaulDalek