-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart rendering breaks around 5000 x-Axis data points #523
Comments
In the meantime I found out that the error in the second graph may result from unbalanced series lengths, so that error may be expected, however the series have the same length for the third graph and it's still broken |
I can add an additional example for failing data around the 5000 data points mark: working (4999 data points) broken (5000 data points) Although the graph is still being rendered it looses the requested gradient. |
Thank you, any news on the release date? I'd be happy to test a beta or rc release as well |
Another month has passed, I can't really take this issue as resolved as we can't use the proposed solution - it still hasn't been released yet. Please advise how to proceed. (Due to internal guidelines we aren't in a position to use branches as reference for our packages) |
bump! |
@bvogel it has been fixed (on the master branch) and on the official deployed Highcharts Export Server. Please try it out :) |
@jszuminski unfortunately we can't use the external server due to company policies, so I'll have to wait for the official release (my test data was deleted already) |
Absolutely, I understand. If you'd like, you can always try to download the package from GitHub. |
Hi, I just tested with:
but still seeing the same error. 5000 x-axis points will break rendering. In contrast to #490 I don't get an 500 error but just a broken graph. |
i.e. can we have this re-opened please? |
I've reopened this issue and added it to our backlog. If the problem indeed persists (we will have to investigate that), we will try to make it a part of one of the upcoming releases. |
Thank you! |
@jszuminski were you able to reproduce? should I sent test data from our end? |
@bvogel if possible, you can share the test data, that would be helpful. You can also try to create a minimal reproducible example in JSFiddle, starting from there: https://jsfiddle.net/ftpyxewh/ |
Hi @jszuminski, this fiddle will work as fiddle but is broken if exported through the server https://jsfiddle.net/5ejsu9go/ this one will work: https://jsfiddle.net/j6ns0d3v/ Some additional data: the export server receives a post with:
|
@jszuminski any news on this, were you able to reproduce the error we are seeing? |
@bvogel I seem to have different errors when exporting this, but do not encounter what you encounter. The good news is that this #561 pull request will introduce many beneficial changes and will allow to detect errors in request/CLI options if they are the ones causing an error so a part of the problem will get solved there; you will get an error or a warning message if the configuration is not optimal or not supported. However, for now, let's get back to the main problem which is the partial rendering of the line chart. Could you please tell me:
|
we use a HTTP POST request, so I have no CLI or json file. The jsfiddles are very close to the requests we send. as mentioned in the previous post we use this code: def request_chart(for_pdf: false)
scaling = for_pdf ? 2 : 1
result = HTTP.post(HIGHCHARTS_EXPORT_SERVER_URL, json: { infile: @chart_options, scale: scaling, type: "jpeg" })
raise HighchartsError, "status: #{result.status.code} reason: #{result.body}" unless result.status.success?
StringIO.new(result.body)
end ^^^ we see the error for with the edit: this is the log from a export server for a failing request
edit 2: you can use this link to get a broken sample: https://capinside.com/products/pictet-digital-hi-eur-lu0386392772/fact_sheet?performance_start_date=2011-01-05&performance_end_date=2024-09-13&peergroup_id=13&add_personalization=false&risk_return_range=1_year and this one (one day less) for a working one https://capinside.com/products/pictet-digital-hi-eur-lu0386392772/fact_sheet?performance_start_date=2011-01-06&performance_end_date=2024-09-13&peergroup_id=13&add_personalization=false&risk_return_range=1_year - and for good measure, this is the page we start from, probably some data can be deduced from the graph in use there: https://capinside.com/p/pictet-digital-hi-eur-lu0386392772?locale=en |
Okay, thank you very much @bvogel! I have successfully managed to reproduce it locally and get the same result as you do: I will now investigate the cause of the problem by debugging what's going on inside the Puppeteer. |
Thank you so much for the update! |
node v20
highcharts version 10.4.0
export server version: 3.1.1
Expected behaviour
Graph rendered correctly (4999 data points)
Actual behaviour
Graph rendered with increasing errors (5000 data points)
graph don't start at the same point any more
Graph broken (5001 data points)
graph is missing 3/4 of data
Reproduction steps
infiles for the cases:
working json
partially broken
broken
The text was updated successfully, but these errors were encountered: