Use status from->to to pick a transition to apply to an issue #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Nov 29, 2024
Comment on lines
225
to
226
| () -> findRequiredTransitionId(downstreamStatus, destIssue)) | ||
| .orElseGet(() -> findRequiredTransitionId(downstreamStatus, destIssue).orElse(null))) |
There was a problem hiding this comment.
This duplicate findRequiredTransitionId call is suspicious... Can statusToTransition actually return an empty optional here? If it does, doesn't it mean findRequiredTransitionId returned an empty optional and thus isn't useful?
There was a problem hiding this comment.
Yeah, that was a bad choice 🙈
The thing is that the transition is cached, but that first attempt to call findRequiredTransitionId may end up failing for some reason (since it's a rest call), so that was a silly attempt to still try and get a transition if it cached the failed attempt (null) BUT why would one cache the null in the first place!? 🤦🏻♂️
It should be better now with nulls not cached.
marko-bekhta
force-pushed
the
feat/change-status-transition-handling
branch
from
3bb733d
to
ca89e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.