Fix deprecation warning, drop sbt 1.0.x support #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
changed the title
Malax
force-pushed
the
malax/fix-deprecation-warning
branch
6 times, most recently
from
e8ac0d4
to
b553c44
Compare
edmorley
reviewed
Oct 31, 2023
Closed
Malax
force-pushed
the
malax/fix-deprecation-warning
branch
2 times, most recently
from
21794b6
to
8a221be
Compare
Malax
force-pushed
the
malax/fix-deprecation-warning
branch
from
8a221be
to
541f9be
Compare
edmorley
approved these changes
Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #231, the sbt plugin injected by this buildpack causes deprecation warnings with sbt
>= 1.5.The fix requires the plugin to use the slash syntax which is only supported in sbt since
1.1. Since version1.0is EOL for some time now and a migration to1.1or later is trivial, this PR removes sbt1.0support instead of providing a special plugin for that version. Error messages have been adjusted accordingly.Fixes #231.
Ref: GUS-W-14387696