Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Check for manifest file errors #18

Open
redsigma opened this issue Jul 21, 2018 · 4 comments
Open

Check for manifest file errors #18

redsigma opened this issue Jul 21, 2018 · 4 comments
Labels

Comments

@redsigma
Copy link
Contributor

The installer doesn't check against missing extras.

@redsigma redsigma changed the title Missing Extra Check Missing Extras Jul 21, 2018
@henrikx henrikx added the Bug label Jul 22, 2018
@henrikx henrikx changed the title Missing Extras Check for metafile errors Jul 22, 2018
@henrikx henrikx changed the title Check for metafile errors Check for manifest file errors Jul 22, 2018
@PhantomGamers
Copy link
Contributor

PhantomGamers commented Aug 1, 2018

I'm working on this RN, have the functionality down, needs more testing but I came across another bug while working on this.

Currently we only add entries that have their 3rd group empty
if (Regex.Match((manifest[i].Replace("\\", "")), "\"(.*?)\";\"(.*?)\";\"(.*?)\";\"(.*?)\"").Groups[3].Value == "")

What's the purpose of this? Currently the last 3 items in the manifest have text in the third entry so they flat out don't show up on the installer at all, spent hours thinking there was a false negative in my code only to realize that haha

EDIT: Also Henrikx do you have discord? Or is this the best way to contact you?

@henrikx

@henrikx
Copy link
Owner

henrikx commented Aug 1, 2018

See #4 @PhantomGamers

@henrikx
Copy link
Owner

henrikx commented Aug 1, 2018

Adding more to it, some extras are made with two extras combined, because they modify the same file. That field in manifest file says something about which extras it links with

@henrikx
Copy link
Owner

henrikx commented Aug 3, 2018

Btw I am in the Unofficial patch Discord under the name @ciken#9165. I prefer that we communicate about bugs and other development here unless something requires immediate action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants