Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use version key for master install in zvm #20

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

hendriknielaender
Copy link
Owner

@hendriknielaender hendriknielaender commented Nov 6, 2023

Overview

This PR introduces a critical update to the Zig Version Manager (zvm) that resolves an issue with the installation of the master version of Zig. Previously, when attempting to install the master version, zvm would not correctly utilize the version key provided in the JSON configuration, leading to installation failures. With this update, zvm now correctly references the version key for master, ensuring that the unique development version of Zig is accurately fetched and installed.

Changes

  • Modified fetchVersionData function to use the version key in the JSON configuration when installing the master version.
  • Added a conditional check in the installation process to determine whether the master version is requested, and if so, to use the unique version identifier provided by the JSON configuration.
  • Implemented additional logging for debugging purposes, providing clear output for each step in the installation process, aiding in future troubleshooting.

Impact

  • Users can now install the master version of Zig without encountering the EmptyVersion error.
  • The installation process for development versions of Zig is more robust and less likely to fail due to mismatches in expected version identifiers.

Notes

This fix is crucial for developers who rely on the cutting-edge features of Zig and need to work with the latest development builds. The zvm's reliability is significantly improved, promoting a smoother development experience for the Zig community.

Closes #17

@hendriknielaender hendriknielaender self-assigned this Nov 6, 2023
@hendriknielaender hendriknielaender merged commit 320c3ea into main Nov 7, 2023
4 checks passed
@hendriknielaender hendriknielaender deleted the install-master branch December 29, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program downloads macos-x86_64 on macos-aarch64 then crashes #28
1 participant