Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overwriting an existing file at the same location #229

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 8, 2024

Motivation

Fix #117
Fix #137

  • Support overwriting an existing file at the same location when in w mode
  • Expose the mode as a property of ZarrIO

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (eae8fb5) to head (17c6ea1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf_zarr/backend.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #229      +/-   ##
==========================================
+ Coverage   85.64%   85.67%   +0.03%     
==========================================
  Files           5        5              
  Lines        1198     1208      +10     
  Branches      297      301       +4     
==========================================
+ Hits         1026     1035       +9     
  Misses        113      113              
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as ready for review November 8, 2024 00:19
@oruebel
Copy link
Contributor Author

oruebel commented Nov 8, 2024

@mavaylon1 this one is ready to review

src/hdmf_zarr/backend.py Outdated Show resolved Hide resolved
@rly rly enabled auto-merge (squash) November 8, 2024 20:03
@rly rly merged commit 049402f into dev Nov 8, 2024
22 checks passed
@rly rly deleted the support_overwrite_file branch November 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Expose mode to NWBZarrIO [Bug]: Cannot overwrite existing HDF5 .nwb file with mode="w"
3 participants