Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover should not be visible for the Integration console #188

Open
tadayosi opened this issue Nov 13, 2023 · 3 comments
Open

Discover should not be visible for the Integration console #188

tadayosi opened this issue Nov 13, 2023 · 3 comments

Comments

@tadayosi
Copy link
Member

Discover should be provided only for the Online console, which is the entrance view for Hawtio Online. Once it's connected to a specific pod, Discover should be disabled.

image

@phantomjinx
Copy link
Member

phantomjinx commented Dec 6, 2023

Disabling the Discover plugin will result in the dropdown being removed as well.

We currently do not have the API in hawtio/react to create a separate plugin that just provides the DropDown.

  • The Plugin API requires a title & component. Can set the component to () -> null but no workaround to title;
  • HawtioSidebar lists all plugins that implement the Plugin interface

Do we change the API at this stage?

@tadayosi
Copy link
Member Author

tadayosi commented Dec 7, 2023

@phantomjinx OK, I understand the issue now. So we need to extend the plugin API, but yeah let's do it after we release GA.

@tadayosi
Copy link
Member Author

@phantomjinx According to @grgrzybek, hawtio/react v1.3.0 already includes a fix for hawtio/hawtio-next#704. You can apply the fix and try resolving the issue now.

@phantomjinx phantomjinx modified the milestones: 2024Q3, 2024Q4 Oct 14, 2024
phantomjinx added a commit to phantomjinx/hawtio-online that referenced this issue Oct 14, 2024
)

* Splits the Discover plugin into 2:
 * Discover Core: preferences and header menu (always active)
 * Discover: page dashboad component (only active if no current connection)

* discover-core
 * Moves preferences to this plugin
 * Moves header menu to this plugin
 * Adds as a new plugin, always active
 * By not including a plugin-path, the plugin will not be listed in the
   nav sidebar

* discover
 * Dashboard only active if the connect-server does not contain a current
   connection
phantomjinx added a commit that referenced this issue Oct 16, 2024
* Splits the Discover plugin into 2:
 * Discover Core: preferences and header menu (always active)
 * Discover: page dashboad component (only active if no current connection)

* discover-core
 * Moves preferences to this plugin
 * Moves header menu to this plugin
 * Adds as a new plugin, always active
 * By not including a plugin-path, the plugin will not be listed in the
   nav sidebar

* discover
 * Dashboard only active if the connect-server does not contain a current
   connection
phantomjinx added a commit that referenced this issue Oct 21, 2024
* Splits the Discover plugin into 2:
 * Discover Core: preferences and header menu (always active)
 * Discover: page dashboad component (only active if no current connection)

* discover-core
 * Moves preferences to this plugin
 * Moves header menu to this plugin
 * Adds as a new plugin, always active
 * By not including a plugin-path, the plugin will not be listed in the
   nav sidebar

* discover
 * Dashboard only active if the connect-server does not contain a current
   connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

No branches or pull requests

2 participants