Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tud_video_n_streaming check #2579

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

HiFiPhile
Copy link
Collaborator

@HiFiPhile HiFiPhile commented Apr 9, 2024

Describe the PR
I met a racing condition with video examples (strangely I didn't caught it in #2538).

With ISO alloc stm->desc.ep[0] is no longer cleared, tud_video_n_streaming() return true when interface is initializing but usbd_edpt_iso_activate() is not yet called. Resulting usbd_edpt_xfer() called before endpoint is ready.

@HiFiPhile HiFiPhile requested a review from kkitayam April 9, 2024 09:27
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, look good to me. Note: host can acutally do probe while streaming to dynamic change streaming parameter. So I guess the current state does not accurately reflect the streaming state. Though we will do a full revise later on.

@hathach hathach merged commit 1195fa8 into hathach:master Apr 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants