[HUB] Prevent status request to invalid ep_num #2404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
If you disconnect a USB hub tusb clears the hub device memory (to zeros). If its a hub, during disconnect it also creates a detach event on hub port 0 to unroll the loop. Problem occurs when it processes this detach event on the now cleared hub device and requests the next hub status packet
tinyusb/src/host/usbh.c
Line 461 in ae364b1
Resulting in this request onto the hub interrupt endpoint
Queue EP 00 with 1 bytes ...
The ep_num of 0 causes some backends to process it as a control transfer instead of a interrupt transfer This was resulting in a td leak on the OHCI backend.
This PR prevents this from occuring.
As USB hub ports start from 1, this should not cause any issues under normal operation.