Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤔 Choose when runs should be triggered by VCS changes. #314

Open
obervinov opened this issue Dec 30, 2023 · 3 comments · May be fixed by #496
Open

🤔 Choose when runs should be triggered by VCS changes. #314

obervinov opened this issue Dec 30, 2023 · 3 comments · May be fixed by #496
Labels
acknowledged enhancement New feature or request

Comments

@obervinov
Copy link

obervinov commented Dec 30, 2023

Operator Version, Kind and Kubernetes Version

  • Operator version: 2.1.0
  • Kind: Workspace
  • Kubernetes version: v1.28.2

YAML Manifest File

apiVersion: app.terraform.io/v1alpha2
kind: Workspace
metadata:
  creationTimestamp: "2023-12-29T21:43:46Z"
  finalizers:
  - workspace.app.terraform.io/finalizer
  generation: 1
  name: dns-workspace
  namespace: terraform-operator
spec:
  agentPool:
    name: kubernetes-tfc-agent-pool
  allowDestroyPlan: true
  applyMethod: manual
  description: For managing the DNS records
  executionMode: agent
  name: dns-workspace
  notifications:
  - emailUsers:
    - obervinov@example.com
    enabled: true
    name: 'Terraform Cloud: DNS'
    triggers:
    - run:applying
    - assessment:check_failure
    - run:completed
    - assessment:drifted
    - run:errored
    - assessment:failed
    - assessment:failed
    type: email
  organization: ***
  tags:
  - dns
  - terraform-operator
  - automatic-deployment
  terraformVersion: 1.6.6
  token:
    secretKeyRef:
      key: token
      name: tfc-operator
  versionControl:
    oAuthTokenID: ***
    repository: infrastructure
  workingDirectory: infra/dns

Output Log

Kubectl Outputs

Question

In the Web UI settings of Terraform Cloud, I can override the VCS Triggers setting by setting the parameter to Only trigger runs when files in specified paths change.
This allows for multi-repository setups with different workspaces to avoid triggering all workspaces at once when a commit is made to the repository. However, I don't see support for this functionality in the API specification through the CRD Workspace.
Is it possible to change the value of VCS Triggers, or will I have to abandon the Terraform operator in favor of manually creating workspaces through the web UI?
Снимок экрана 2023-12-30 в 13 30 25

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
@obervinov obervinov added the question Further information is requested label Dec 30, 2023
@razorsk8jz
Copy link

This is also a requirement for us as we trigger based on pattern changes using more of a monorepo for our terraform projects - this makes the operator unusable for us

@lee5i3
Copy link

lee5i3 commented Jan 12, 2024

We need this too, unfortunately it keeps putting the triggers back every time we change the triggers in the UI, we either need this functionality or ignore changes in the UI

@iBrandyJackson iBrandyJackson added enhancement New feature or request acknowledged and removed question Further information is requested labels Apr 2, 2024
@baptman21 baptman21 linked a pull request Oct 14, 2024 that will close this issue
@obervinov
Copy link
Author

obervinov commented Oct 14, 2024

@razorsk8jz @lee5i3 If you don’t mind, please support this PR (it should solve the problem described) #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged enhancement New feature or request
Projects
None yet
4 participants