Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting borderWidth to 0, the + icon still has a borderLeft #17

Open
efstathiosntonas opened this issue Mar 8, 2018 · 2 comments
Assignees

Comments

@efstathiosntonas
Copy link

efstathiosntonas commented Mar 8, 2018

<Item>
    <Text style={{ marginTop: 10, marginBottom: 10 , fontSize: 12}}>
          Choose Distance
     </Text>
     <UIStepper
          borderWidth={0}
           tintColor={'#4C9DD0'}
           textColor={'#4C9DD0'}
           displayValue
           initialValue={this.state.range}
           maximumValue={1000}
           value={this.state.value}
           onIncrement={this.increment}
           onDecrement={this.decrement}
     />
</Item>

results to:
screen shot 2018-03-08 at 16 15 23

This line (319) causes the border to appear in UIStepper.js
borderLeftWidth: vertical ? 0 : displayValue ? 1 : 0

if i set displayValue ? 0 : 0 then border disappears as expected.

@hannigand
Copy link
Owner

Hey @efstathiosntonas, thanks for raising this issue.

I'll take a look and get a fix shipped as soon as possible.

@hannigand hannigand self-assigned this Mar 8, 2018
@efstathiosntonas efstathiosntonas changed the title When setting borderRadius to 0, the + icon still has a borderLeft When setting borderWidth to 0, the + icon still has a borderLeft Mar 8, 2018
@hannigand
Copy link
Owner

Just to keep you in the loop @efstathiosntonas, I'll release a fix for this later on this evening (BST).

Sorry for the delay in shipping a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants