Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display issue when no groups are present #74

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 14, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

当目前链接没有分组时,将不会显示移动按钮。

How to test it?

测试不存在分组以及存在分组时,移动按钮是否显示。

Which issue(s) this PR fixes:

Fixes #73

Does this PR introduce a user-facing change?

解决没有分组时点击移动会出现空白项的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 14, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 14, 2024 08:08
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

f2c-ci-robot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5276e22 into halo-sigs:main Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

没有自定义分组时,点击移动按钮会出现空白项
2 participants