Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Output rss.xml is not ordered by pubDate #26

Open
LeslieLeung opened this issue Dec 20, 2023 · 2 comments
Open

[bug] Output rss.xml is not ordered by pubDate #26

LeslieLeung opened this issue Dec 20, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@LeslieLeung
Copy link
Contributor

输出的RSS没有按照时间排序,见 https://ameow.xyz/rss.xml

可能是以下这个地方使用了 map 导致丢失了顺序。
https://github.com/halo-dev/plugin-feed/blob/0c648ca49e7415a2d19d565b9f095d6e439b4061/src/main/java/run/halo/feed/FeedServiceImpl.java#L154C14-L154C21

@JohnNiang
Copy link
Member

Hi @LeslieLeung , thanks for reaching out here.

这里确实错误地使用了 flatMap 导致最终排序不稳定,如果换成 concatMap 应该可以解决问题。如果 @LeslieLeung 有兴趣的话, 非常欢迎提交 PR 修复这个问题。

/good-first-issue

Copy link

f2c-ci-robot bot commented Dec 20, 2023

@JohnNiang:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Hi @LeslieLeung , thanks for reaching out here.

这里确实错误地使用了 flatMap 导致最终排序不稳定,如果换成 concatMap 应该可以解决问题。如果 @LeslieLeung 有兴趣的话, 非常欢迎提交 PR 修复这个问题。

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 20, 2023
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 20, 2023
LeslieLeung added a commit to LeslieLeung/plugin-feed that referenced this issue Jan 13, 2024
f2c-ci-robot bot pushed a commit that referenced this issue Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants