Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #81

Open
hallelujah opened this issue Feb 2, 2017 · 0 comments
Open

TODO #81

hallelujah opened this issue Feb 2, 2017 · 0 comments

Comments

@hallelujah
Copy link
Owner

hallelujah commented Feb 2, 2017

Goal:

  • Use only Mail gem to keep it simple
  • Separate tests so they have meaning
  • Separate features implemented in this gem into small ones:
    • MX DNS resolution
    • Blacklist domains
    • Other ideas ?

Why?

Thing is that it become unmaintainable as features are really mixed together, I tried to implement DNS timeout but I could no achieve it due to many places to change and tests are good but not separated enough

So my idea was to separate features into small gems:

  • standalone but may be combined
  • using I18n
  • testable
@hallelujah hallelujah added this to the Version 1 - Gem revamped milestone Feb 2, 2017
@hallelujah hallelujah added the v1 label Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant