Passes --public-ip-address to hailctl dataproc start
#14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for public-ip-address in dataproc * Use the same code style as previous code --------- Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
ehigham
approved these changes
Aug 5, 2024
cjllanwarne
requested changes
Aug 5, 2024
Comment on lines
196
to
197
| Opt( | ||
| help='Allow nodes to have a public IP address, and hence make requests on the public internet (default is internal-only from dataproc 2.2).' |
There was a problem hiding this comment.
From your description:
since we need internet access to install some of our dependencies
Is there any use case where someone would want to disable public IP addresses and not have the dependencies set up? If not, should this just be forced to be true (instead of being an option)?
There was a problem hiding this comment.
Good point, looks like we get the list of dependencies from hail/python/hailtop/hailctl/deploy.yaml, which is generated when we build the wheel, so there is not a way for the user to avoid using the packages we specify. Revised to just make this part of the command string instead of an option!
|
FWIW, this change worked fixed our dataproc initialisation :) |
iris-garden
changed the title
--public-ip-address arg to hailctl dataproc start and enables it by default--public-ip-address to hailctl dataproc start
cjllanwarne
approved these changes
Aug 7, 2024
ehigham
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14652.
See populationgenomics#346. Thanks for the contribution @illusional!
Gives Dataproc clusters started via
hailctl dataproc startinternet access by default, since we need it to install some of our dependencies, per the error message in the linked issue.