Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfLocation now gives the complete address of an S3 bucket item #199

Open
eselkin opened this issue Mar 18, 2020 · 4 comments
Open

pdfLocation now gives the complete address of an S3 bucket item #199

eselkin opened this issue Mar 18, 2020 · 4 comments

Comments

@eselkin
Copy link
Contributor

eselkin commented Mar 18, 2020

Now that pdfLocation gives the complete address of an S3 bucket object, the value needs to be provided to the user in the exact format it comes from the backend.

@ldaws003
Copy link
Contributor

Hey eselkin, I would like to take a look at this. In which component(s) does this bug occur in?

@eselkin
Copy link
Contributor Author

eselkin commented Mar 30, 2020

So, I handled it on staging, but I think I broke something. Now the "Load More Agendas" is broken. So I need to fix that. I'm not quite sure how I broke that, but it seems I did... unless it was already broken on staging.

@ldaws003
Copy link
Contributor

ldaws003 commented Apr 3, 2020

It was working the last time I looked at it. It seems for some reason that the reduce method of agendaList in agendas.js doesn’t use the state.agendaItems as an initial value after clicking the load more button. Although it does on initial rendering. state.agendaItems still exists and is defined but the accumulator is undefined.

@eselkin
Copy link
Contributor Author

eselkin commented Apr 9, 2020

Hmm, is this something you'd consider working on? Also, possibly updating the libraries... I've got a number of warnings about the need to update a lot of packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants