Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifying description for complex structure #6

Open
computron opened this issue Dec 19, 2018 · 2 comments
Open

simplifying description for complex structure #6

computron opened this issue Dec 19, 2018 · 2 comments

Comments

@computron
Copy link
Contributor

robocrys mp-744259

Generates what looks like a lot of junk (the text might be correct, but it is difficult to human read). One thing to help with this might be to organize the text by section: local environment, connectivity, tilt angles - rather than by site. Also if the text is long, to give only the basics (e.g. skip all the various bond lengths) and prompt the user if they would like to know more. But just having things in clearer sections, maybe multiple paragraphs would help.

Note that according to MP, this is garnet structured (the tag says it is), but this is not picked up by robocrystallographer.

@utf
Copy link
Member

utf commented Dec 19, 2018

My worry about splitting the description into multiple sections is that it even more confusing. Especially when the description is long, it will be difficult to keep track of which atoms are which. Perhaps the code could produce separate paragraphs for each structure component, however, this wouldn't affect your example.

In your example, the text can be cleaned somewhat by adding the --no-symmetry-labels option. This will all e.g. Sn sites together rather than listing inequivalent sites.

To make this even clearer, I plan to add a -merge-similar-sites option which will combine the descriptions of all sites with the same geometry but different bond lengths/angles. In your example, the text would change from:

There are two inequivalent Ca2+ sites. In the first Ca2+ site, Ca2+ is bonded in a distorted body-centered cubic geometry to eight O2- atoms. There are a spread of Ca–O bond distances ranging from 2.36–2.59 Å. In the second Ca2+ site, Ca2+ is bonded in a distorted body-centered cubic geometry to eight O2- atoms. There are a spread of Ca–O bond distances ranging from 2.41–2.56 Å.

to

There are two inequivalent Ca2+ sites. In bot Ca2+ sites, Ca2+ is bonded in a distorted body-centered cubic geometry to eight O2- atoms. There are a spread of Ca–O bond distances ranging from 2.36–2.59 Å.

Repeat this for all the other atoms and the description will be considerably shorter.

@computron
Copy link
Contributor Author

yes that looks much cleaner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants