Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples via Docker: missing mli-resources clone & jupyter to be run w/ --allow-root #9

Open
dvorka opened this issue Sep 21, 2018 · 5 comments
Assignees

Comments

@dvorka
Copy link

dvorka commented Sep 21, 2018

In order to successfully install examples using Docker I did the following changes:

  • There seems to be missing step which clones mli-resources GitHub repository. Perhaps RUN git clone https://github.com/h2oai/mli-resources.git should be added to Dockerfile (I cloned repo manually).
  • Jupyter refuses to start under root - consider adding --allow-root parameter: docker run -i -t -p 8888:8888 <image_id> /bin/bash -c "/opt/conda/bin/conda install jupyter -y --quiet && /opt/conda/bin/jupyter notebook --notebook-dir=/mli-resources --ip='*' --port=8888 --no-browser --allow-root" and/or suggest to run it under a normal user.
  • Perhaps it would be worth to suggest user to use URL provided by Jupyter after it starts - it contains auth token (README.md, step 9.).
@jphall663
Copy link
Contributor

DOH - this is a regression ... ok we will update. Thanks for making us aware.

@jphall663
Copy link
Contributor

jphall663 commented Sep 21, 2018

@dvorka sorry this is all related to a very rushed, half-assed upgrade to py 3.6 by yours truly. I'm going through the notebooks 1-by-1 one right now. Give me a few hours ... :face_palm:

@jphall663
Copy link
Contributor

I'm at "works for me" - so I dare not close this yet. This was a mess ... I wasn't expecting it to be this difficult to go from py35 to py36 (I do this to use the shap package).

@jphall663
Copy link
Contributor

jphall663 commented Sep 22, 2018

@navdeep-G IF you have time - or we get more complaints - can you remove your old docker image, rebuild from the new dockerfile, and run all the notebooks, including the ones for comparing explanations ... it takes forever. sorry. If you get no errors we can probably close.

@dvorka
Copy link
Author

dvorka commented Sep 22, 2018

@jphall663 No problem. I really appreciate your prompt response and effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants