Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new shape for the North sea #225

Open
OnnoEbbens opened this issue Aug 24, 2023 · 5 comments
Open

Add new shape for the North sea #225

OnnoEbbens opened this issue Aug 24, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@OnnoEbbens
Copy link
Collaborator

No description provided.

@KeesdeVriesW
Copy link

good plan! Please include other Rijkswateren as well. My suggestion: IJsselmeer/ Markermeer, Noordzeekanaal&IJ, Nieuwe Waterweg and all getijde-components of Grote Wateren.

@OnnoEbbens
Copy link
Collaborator Author

I found this WFS server from RWS that has the shapes we need. Using the existing nlmod function it is fairly easy to load this data.

url = "https://geo.rijkswaterstaat.nl/services/ogc/gdr/omgevingswet/ows?service=WFS"
layer = 'omgevingswet:oppervlaktewaterlichamen_rijk'
extent = dims.get_extent(ds)
gdf_swater = nlmod.read.webservices.wfs(url, layer, extent=extent)

The only difficult part is to find the right layer. The layers related to surface water are:

  • 'grote_rivieren_bergend_deel_rivierbed',
  • 'grote_rivieren_rivierbed',
  • 'grote_rivieren_stroomvoerend_deel_rivierbed',
  • 'kanalen_beperkingengebied_rijk',
  • 'kustfundament_rijk',
  • 'noordzee_beperkingengebied_rijk',
  • 'noordzee_buiten_zone_dv_lat_beperkingengebied_rijk',
  • 'oppervlaktewater_geen_kanaal_beperkingengebied_rijk',
  • 'oppervlaktewaterlichamen_rijk'

I think it is nice to combine this data into a single shapefile with the surface waters suggested by @KeesdeVriesW. If someone can do this, the geopackages of these layers can be found below
geopackages_rws_oppwater.zip

@dbrakenhoff
Copy link
Collaborator

Partially solved by #242 where the cells with sea are derived from the DTM.

Keeping this issue open to add function to obtain the shapefile @OnnoEbbens proposed. Once this is done, we should remove the old shapefile.

@dbrakenhoff dbrakenhoff added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 2, 2023
@dbrakenhoff
Copy link
Collaborator

@KeesdeVriesW any chance you have a good shapefile that you'd be willing to commit?

@KeesdeVriesW
Copy link

@KeesdeVriesW any chance you have a good shapefile that you'd be willing to commit?

I wll have to look around. Would be better to use a public source like suggested by @OnnoEbbens. Opening the shapes and combineing them, if required adding defaul water level (NAP), mean Bottom level and mean resistance.

@bdestombe bdestombe added this to NHFLO Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in NHFLO Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants