Final version of pycbc_pygrb_plot_snr_timeseries
#4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ifos, | ||
| slide_dict, | ||
| opts.veto_file, | ||
| hide_onsource=hide_onsource |
There was a problem hiding this comment.
You are only using hide_onsource once, so consider doing instead
hide_onsource=(not opts.onsource)
titodalcanton
approved these changes
Nov 25, 2024
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the sixth in the series started in PR #4929. Much like PRs #4947 and #4950, this PR provides a version of
pycbc_pygrb_plot_snr_timeseriesthat uses veto and segments files, as well as the utilities introduced recently to streamline the PyGRB results scripts. Additionally,pycbc_pygrb_plot_snr_timeseriesnow has an option to activate plotting the onsource (by default the onsource is not shown) and this is handled in its dedicated workflow generator function.Standard information about the request (and the following ones that will be linked to this)
This is a: a new feature enabling veto definer file usage in PyGRB. Utilities and scripts in results production are being streamlined along the way.
This change affects: PyGRB
This change changes: result presentation / plotting and scientific output.
Should this change break the standard automated test running
--helpfor PyGRB plotting scripts, I will add some workarounds to avoid this. If needed, these will likely be empty functions: the plotting scripts will be progressively renovated in the whole series of PRs.Motivation
Now that the workflow generator passes the veto definer file to the jobs where needed, its usage in the PyGRB results scripts is possible.
Testing performed
The totality of the changes that will be broken down in multiple PRs was tested on GRB 170817A data by producing a full results webpage (see here).