Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emboldened edge cases #199

Open
2 tasks
Sejsel opened this issue Aug 22, 2023 · 1 comment
Open
2 tasks

Emboldened edge cases #199

Sejsel opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
Log Manager 1.12

Comments

@Sejsel
Copy link
Member

Sejsel commented Aug 22, 2023

  • Emboldened can be legitimately applied in the middle of a fight in case the fight is ongoing while the Emboldened wing changes, we do not currently handle this (and the log processing outright fails)
  • Emboldened can be applied at the end of a log, we need to ignore it. This is especially notable if going from a CM fight to a normal fight in a wing that does not have Emboldened disabled.
@Sejsel Sejsel added the bug Something isn't working label Aug 22, 2023
@Sejsel Sejsel added this to the Log Manager 1.10 milestone Aug 22, 2023
@Sejsel
Copy link
Member Author

Sejsel commented Aug 22, 2023

In c435f69, I fixed the processing outright failing in case there is no initial buff with emboldened, but it appears later in the fight. We still need to handle these two cases correctly, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
arcdps Log Manager
Status: Bugs
Milestone
Log Manager 1.12
Development

No branches or pull requests
1 participant
@Sejsel