From d71b35536404e5e9137638e30a019ae5d76c7de4 Mon Sep 17 00:00:00 2001 From: Linkaaaaa Date: Sat, 4 May 2024 12:45:08 +0200 Subject: [PATCH] Analytics: Fix Skorvald false failure when he's invulnerable at 1% and all players are dead --- ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs | 3 +++ EVTCAnalytics/Processing/EncounterDataProvider.cs | 3 +++ 2 files changed, 6 insertions(+) diff --git a/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs b/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs index 6332abc0..59874fa1 100644 --- a/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs +++ b/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs @@ -195,6 +195,9 @@ x.Profession is Profession.Thief or Profession.Engineer or Profession.Ranger && log.Encounter == Encounter.TempleOfFebe && log.GameBuild >= GameBuilds.TempleOfFebeHealthFix, "Fixed NM detection for Temple of Febe"), + new LogUpdate(log => log.ParsingVersion < new Version(1, 11, 1, 1) + && log.Encounter == Encounter.Skorvald, + "Fix success detection for Skorvald when all players are dead while the boss is invulnerable at 1%"), // When adding a new update, you need to increase the revision (last value) of the version in the .csproj file // unless the version changes more significantly, in that case it can be reset to 0. }; diff --git a/EVTCAnalytics/Processing/EncounterDataProvider.cs b/EVTCAnalytics/Processing/EncounterDataProvider.cs index 5ff1b9c6..56822514 100644 --- a/EVTCAnalytics/Processing/EncounterDataProvider.cs +++ b/EVTCAnalytics/Processing/EncounterDataProvider.cs @@ -308,6 +308,9 @@ private IEncounterData GetPvEEncounterData(Encounter encounter, Agent mainTarget // Skorvald the Shattered is the same species in Challenge and Normal mode, // unlike most other fractal CM encounters return GetDefaultBuilder(encounter, mainTarget) + .WithResult(new AnyCombinedResultDeterminer( + new AgentKillingBlowDeterminer(mainTarget), + new BuffAppliedBelowHealthThresholdDeterminer(mainTarget, 0.9f, SkillIds.Determined895))) .WithModes(new AgentHealthModeDeterminer(mainTarget, 5_550_000)) .Build(); }