Skip to content

Commit

Permalink
Analytics: Fix Skorvald false failure when he's invulnerable at 1% an…
Browse files Browse the repository at this point in the history
…d all players are dead
  • Loading branch information
Linkaaaaa committed May 4, 2024
1 parent 0b693b2 commit d71b355
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ x.Profession is Profession.Thief or Profession.Engineer or Profession.Ranger
&& log.Encounter == Encounter.TempleOfFebe
&& log.GameBuild >= GameBuilds.TempleOfFebeHealthFix,
"Fixed NM detection for Temple of Febe"),
new LogUpdate(log => log.ParsingVersion < new Version(1, 11, 1, 1)
&& log.Encounter == Encounter.Skorvald,
"Fix success detection for Skorvald when all players are dead while the boss is invulnerable at 1%"),
// When adding a new update, you need to increase the revision (last value) of the version in the .csproj file
// unless the version changes more significantly, in that case it can be reset to 0.
};
Expand Down
3 changes: 3 additions & 0 deletions EVTCAnalytics/Processing/EncounterDataProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ private IEncounterData GetPvEEncounterData(Encounter encounter, Agent mainTarget
// Skorvald the Shattered is the same species in Challenge and Normal mode,
// unlike most other fractal CM encounters
return GetDefaultBuilder(encounter, mainTarget)
.WithResult(new AnyCombinedResultDeterminer(
new AgentKillingBlowDeterminer(mainTarget),
new BuffAppliedBelowHealthThresholdDeterminer(mainTarget, 0.9f, SkillIds.Determined895)))
.WithModes(new AgentHealthModeDeterminer(mainTarget, 5_550_000))
.Build();
}
Expand Down

0 comments on commit d71b355

Please sign in to comment.