Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #27

Open
9 tasks
ctcyang opened this issue Jun 30, 2021 · 0 comments
Open
9 tasks

Code Cleanup #27

ctcyang opened this issue Jun 30, 2021 · 0 comments

Comments

@ctcyang
Copy link
Collaborator

ctcyang commented Jun 30, 2021 •
edited
Loading

Some TODOs:

  • make include order follow Google C++ style guide
  • make code follow clang-tidy
  • get rid of #define private public, either by making all classes structs or adding accessors
  • move unit tests to within each folder and of naming spgemm_test.cu
  • add Makefile support for unit tests
  • get rid of env vars, by making global static context object
  • make CSR only vs. CSRCSC matrix granularity rather than global granularity
  • change std::cout's to use GLOG or some other type of logging library
  • get rid of Boost dependecies on program_options and test with commandline flag library such as gflags and googletest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctcyang