You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this library. I am using it as SPM dependency and recognized the following bug:
The PunycodeSwift library returns "http://www.ラーメン.寿司.co.jp".idnaEncoded! as xn--http://www-.xn--4dkp5a8a.xn--sprr0q.co.jp and "https://test.com".idnaEncoded! as xn--https://test-.com
I am posting this here, because clearly the PunycodeSwift is just doing its job here, but TLDExtractSwift has this as example in its readme.
Possible solutions:
remove example
provide a way to apply idna encoding only to parts that are not the protocol or other parts of URLs that should not be encoded. For that, TLDExtractSwift only needs one extra method calling into PunycodeSwift, transforming the individual url components.
save the protocol definition at the beginning of the url string, so the user can apply Punycode to the individual parts and then re-assemble the URL himself
The text was updated successfully, but these errors were encountered:
Thanks for this library. I am using it as SPM dependency and recognized the following bug:
The PunycodeSwift library returns
"http://www.ラーメン.寿司.co.jp".idnaEncoded!
asxn--http://www-.xn--4dkp5a8a.xn--sprr0q.co.jp
and"https://test.com".idnaEncoded!
asxn--https://test-.com
I am posting this here, because clearly the PunycodeSwift is just doing its job here, but TLDExtractSwift has this as example in its readme.
Possible solutions:
The text was updated successfully, but these errors were encountered: