Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust oco order trading panel ui #403

Open
Zkffkah opened this issue Jun 13, 2019 · 4 comments
Open

Adjust oco order trading panel ui #403

Zkffkah opened this issue Jun 13, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Zkffkah
Copy link

Zkffkah commented Jun 13, 2019

Currently, there are two row in the oco trading panel, one for above and one for below. But mosly we just use one of them because the order direction is the same. So we can change this to one row and add two button ( >,< or above,below) on the left of the price, it's easier to understand and easier to use. And it's easier to implement amount in btc value for it.

@Zkffkah Zkffkah added the enhancement New feature or request label Jun 13, 2019
@badgerwithagun
Copy link
Member

Actually I think we're just sort of abusing the OCO panel. It's intended to place two orders (a take profit and a stop-limit), only one of which will fill.

You can only specify one order if you wish, but that's mostly because it was a quick way for me to implement "soft" limit orders without any special code!

What I think we should do is add an "on exchange" checkbox in the Limit Order panel (as on the stop panel). If that is set, we create a one-sided OCO (again, as we do on the stop panel).

Then add validation in the OCO panel forcing you to specify both sides, just to avoid confusion.

@Zkffkah
Copy link
Author

Zkffkah commented Jun 17, 2019

Yeah, but there are some difference here. The ladder buy should use the low oco, stoploss should use the low oco and the take profit use the high oco. Need something to set it up.

@badgerwithagun
Copy link
Member

I see. I don't want to lose what OCO already does though - I use this a lot (set both a take-profit and a stop-loss, and one cancels the other).

Why does my proposal not work for you? The effect would be the same: just use the Limit or Stop Panels with "on exchange" turned off. If I understand you correctly, this is exactly what you want. It would create exactly the same orders (one-sided OCO jobs) with exactly the same UI behaviour (if you add the BTC amount to the limit and stop panels, you get it for free).

@Zkffkah
Copy link
Author

Zkffkah commented Jun 17, 2019

Yeah, we can do it in stop panel. But we need to add a option there to achieve what I want, need a place to choose if it's a oco high job or oco low job. Because stop limit order panel just use high job for buy and low job for sell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants