Improve styling of right panel tabs #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuhabitela
commented
Nov 7, 2024
manuhabitela
force-pushed
the
issue-1011-tab-styles
branch
from
f1fcf65
to
b7029ed
Compare
hexaltation
suggested changes
Nov 8, 2024
manuhabitela
force-pushed
the
issue-1011-tab-styles
branch
from
b7029ed
to
7958282
Compare
dsagal
added
preview
|
Deployed commit |
Those few visual changes (colors, borders, font weight) make it easier to understand what tab is the selected one in the right tab panel.
manuhabitela
force-pushed
the
issue-1011-tab-styles
branch
from
7958282
to
3950988
Compare
|
Deployed commit |
georgegevoian
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Those few visual changes (colors, borders, font weight) make it easier to understand what tab is the selected one in the creator panel.
Proposed solution
Follow the new design from here.
Related issues
Fixes #1011.
Has this been tested?
I don't think this needs any tests since those are purely visual changes but let me know if I'm mistaken.
Screenshots / Screencasts
Here is a preview of the changes in light and dark modes:
tabs.mp4