Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordigh/update stable docker build #1103

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jul 11, 2024

I did it this way because the two builds aren't close enough to be a single one. It was easier to duplicate a little code than to create more abstractions.

My original commit messages follow:

  • 6162de8
    workflows: add a dummy ext to the stable build

See a437dfa for details

  • c4f06be
    workflows: use variable tags for the stable build

This will make it easier to do some testing while I make sure that
this build is correct.

  • 059b2cd
    workflows: don't build stable twice, just push it twice

This now matches the docker_latest.yml setup. No point building
grist-ee/grist twice.

This now matches the `docker_latest.yml` setup. No point building
grist-ee/grist twice.
This will make it easier to do some testing while I make sure that
this build is correct.
@paulfitz paulfitz self-requested a review July 12, 2024 12:59
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible. Will approve on confirmation that the images built:

  • Have no ext material in grist-oss.
  • Shows an enterprise banner for grist-ee.
  • Responds to "GRIST_ACTIVATION=dud-activation` environment variable in grist-ee and grist.

@jordigh jordigh force-pushed the jordigh/update-stable-docker-build branch from 059b2cd to ee1bdbf Compare July 12, 2024 16:15
@jordigh jordigh merged commit 6760416 into main Jul 12, 2024
12 checks passed
@jordigh jordigh deleted the jordigh/update-stable-docker-build branch July 12, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants