Fixes grist-oss experiemental accidentally including grist-ee code #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spoffy
force-pushed
the
spoffy/fix-oss-having-ee
branch
3 times, most recently
from
9ddf564
to
1508e4e
Compare
jordigh
reviewed
Jul 8, 2024
jordigh
force-pushed
the
spoffy/fix-oss-having-ee
branch
from
1508e4e
to
7efabc8
Compare
jordigh
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where grist EE code was accidentally being included in the grist-oss docker build.
This appears to be an issue with docker caching build contexts (although this isn't 100% confirmed).
The result is that when Grist-oss is built without the
extbuild context, it behaves as if it's using a previous version of the build context.The fix is to explicitly provide an empty
extdirectory, so docker recognises that it's a new, empty value.