Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent indentation in compile_all.py scripts may have unintended consequences #33

Open
timmattison opened this issue Apr 20, 2022 · 0 comments

Comments

@timmattison
Copy link

While converting the Python 2 scripts to Python 3 today I noticed that all of the compile_all.py scripts are very similar. However, a few of them have slightly different formatting. In each compile_all.py the code checks to see if the action value is equal to measure. In the following files this code is indented an extra level:

Fortran/compile_all.py
Java/compile_all.py
Lua/compile_all.py
JRuby/compile_all.py
FSharp/compile_all.py
Perl/compile_all.py
Java-GraalVM/compile_all.py
compile_all.py
Chapel/compile_all.py
Ada/compile_all.py
Racket/compile_all.py
Go/compile_all.py
OCaml/compile_all.py

The effect of this is that in the files in this list check to see if the Makefile file exists and then later check to see if the action is measure. The files that are not in this list check if the action is measure whether or not the Makefile exists.

When action is equal to measure the compile_all.py script sleeps for 5 seconds. I have not looked into how this affects the outcome but the scripts should probably be consistent even if there's no effect on the end results. I'm assuming that the check should only happen when Makefile exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant