Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unsupported Docker Compose features #580

Open
davidkopp opened this issue Dec 5, 2023 · 3 comments
Open

Check unsupported Docker Compose features #580

davidkopp opened this issue Dec 5, 2023 · 3 comments
Assignees

Comments

@davidkopp
Copy link
Contributor

At the moment GMT only supports a subset of the Docker Compose specification.

It would make sense to check if there are unsupported features used in a usage_scenario.yml and throw an error, so the user gets aware of it.

In this context, it would make sense to introduce a new runner argument --skip-unsupported so unsupported features get skipped.

This idea was proposed by @ArneTR in the comment https://github.com/green-coding-berlin/green-metrics-tool/pull/568/files#r1413023920

@ribalba
Copy link
Member

ribalba commented Dec 5, 2023

Just for reference we do some checking here:
schema_checker = SchemaChecker(validate_compose_flag=True)
We could probably use this to implement this functionality.

@ArneTR
Copy link
Member

ArneTR commented Dec 22, 2023

I think they flag to go is this: ignore_extra_keys=False (https://github.com/green-coding-berlin/green-metrics-tool/blob/11b2fe8165030745c82016b31e023407d81da484/lib/schema_checker.py#L125)

Prioritized this issue for Q1. I think it should be rather easy to set up. More work will be changing the example applications

@ArneTR
Copy link
Member

ArneTR commented Dec 22, 2023

Also another thing we need to bring into this feature: This needs to be the standard flag for exectuion when running in cron/cluster mode. So it has to also be brought into the jobs.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants