Added shift+enter to run query in raw query editor #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey guys! :) any news about this? |
|
Hey @nadav-dav - apologies for the delay, there were some unexpected side-effects that we're looking at before we can give a full review here 😊 thank you for the contribution and for checking in! |
|
Any update? |
aangelisc
reviewed
Oct 31, 2024
| if (e.key === 'Enter' && e.shiftKey) { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| onRawQueryChange(); |
There was a problem hiding this comment.
Suggested change
| onRawQueryChange(); | |
| onRawQueryChange(editorRef.current?.getValue() || ''); |
aangelisc
reviewed
Oct 31, 2024
|
|
||
| const onRawQueryChange = (kql: string) => { | ||
| const onRawQueryChange = () => { |
There was a problem hiding this comment.
Suggested change
| const onRawQueryChange = () => { | |
| const onRawQueryChange = useCallback( | |
| (kql: string) => { | |
| reportInteraction('grafana_ds_adx_raw_editor_query_blurred'); | |
| if (kql !== props.query.query) { | |
| props.setDirty(); | |
| props.onChange({ | |
| ...props.query, | |
| query: kql, | |
| }); | |
| props.onRunQuery(); | |
| } | |
| }, | |
| [props] | |
| ); |
aangelisc
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Hi @nadav-dav, apologies for the delay in reviewing this. I've suggested some changes as the current implementation has some lint issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shift+enter to run query in raw query editor :)