Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace submodules with regular folders under publish-plugin repository #182

Open
vlsi opened this issue Feb 19, 2023 · 0 comments
Open

Replace submodules with regular folders under publish-plugin repository #182

vlsi opened this issue Feb 19, 2023 · 0 comments

Comments

@vlsi
Copy link
Contributor

vlsi commented Feb 19, 2023

The current setup with submodules makes it hard to land PRs that touch both e2e and publish-plugin code.

I incline using a single repository would simplify maintenance a lot.

Here's an example: #145 (comment)

It will most likely fails, as the version is timestamp based to avoid problem described in #153 (in addition the version is not properly set in the multi-module e2e project as I mentioned in the comment a few days ago).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlsi