Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pull request template #442

Open
Ainali opened this issue Nov 3, 2024 · 5 comments
Open

Improve pull request template #442

Ainali opened this issue Nov 3, 2024 · 5 comments
Labels
documentation ✍️ Improvements or additions to documentation good first issue Good for newcomers

Comments

@Ainali
Copy link
Member

Ainali commented Nov 3, 2024

Description

For many of my latest PRs which have been updating queries to either match new modeling choices on Wikidata or a changed reality (new ministries etc.) the types have not felt great. It is neither a bug nor a new feature. Could we add a type called query maintenance or something similar?

@Abbe98
Copy link
Member

Abbe98 commented Nov 4, 2024

We should properly have an "other" option.

@Abbe98 Abbe98 added the documentation ✍️ Improvements or additions to documentation label Nov 4, 2024
@Ainali
Copy link
Member Author

Ainali commented Nov 4, 2024

Come to think on it, should it really be a checkbox? Wouldn't a reminder text about setting a label be better? (Can new users see the available labels?)

@Abbe98
Copy link
Member

Abbe98 commented Nov 4, 2024

Should external contributors be responsible for classifying/labeling pull requests to begin with? It's not like that is the task which saves us time...

@Ainali
Copy link
Member Author

Ainali commented Nov 4, 2024

That's a really good point. Perhaps we should remove that entire section from the template, and then the first reviewer assigns labels if needed.

@Abbe98
Copy link
Member

Abbe98 commented Nov 4, 2024

Yeah I think so.

@Ainali Ainali added the good first issue Good for newcomers label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ✍️ Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants